Fixes #366: Add compatibility for using CommonJs #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or GulpJs which does yet support ES6, - Install common-exports to be able to convert the package to CommonJs. - Update the package to not be type=module. - Update the file extensions to .mjs (I also don't like this, but the alternative of .cjs was not compatible) - Add a gulpfile.js and babel.config.js to be able to run common-exports. - Create the CommonJs files in a new cjs directory. - Add a duplicate of the test.js file to be able to test the CommonJs compiled files. - Add signal-exit since the latest version is a dependency of mozjpeg to prevent failures with onExit missing.
…re compiled files - There are three files (test.js, gulpfile.js and babel.config.js) which necessarily use require syntax. To remove these errors, I have reduced prefer-module level to warning.
|
Thanks, but Gulp does support ESM. |
Repository owner
locked as resolved and limited conversation to collaborators
May 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366
Add compatibility for using CommonJs since this package is intended for GulpJs which does yet support ES6,