Skip to content

Add support for Dart Sass #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2018
Merged

Add support for Dart Sass #283

merged 4 commits into from
Jun 27, 2018

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jun 13, 2018 •
edited by sindresorhus
Loading

Fixes #278

@nex3
Copy link
Contributor Author

nex3 commented Jun 13, 2018

cc @xzyfer

@nex3 nex3 mentioned this pull request Jun 13, 2018
Closed
7 tasks
@sindresorhus
Copy link
Owner

I still think we should not depend on node-sass by default. One of the benefits of dart-sass is also that it's much less painful to install. Users should be free to pick either and we should not be opinionated about which one they pick.

@nex3
Copy link
Contributor Author

nex3 commented Jun 25, 2018

That was my original plan, but @xzyfer had the opposite request. I'll update the PR to do that instead.

@nex3
Copy link
Contributor Author

nex3 commented Jun 25, 2018

Updated.

@sindresorhus sindresorhus merged commit 64f6444 into sindresorhus:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @sindresorhus