Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeScript types for Promise API #1344

Merged
merged 4 commits into from
Jul 5, 2020
Merged

Fix TypeScript types for Promise API #1344

merged 4 commits into from
Jul 5, 2020

Conversation

szmarczak
Copy link
Collaborator

Fixes #1312

@szmarczak szmarczak merged commit 676be6d into master Jul 5, 2020
@szmarczak szmarczak deleted the buggyts branch July 5, 2020 20:29
@sindresorhus
Copy link
Owner

Thanks for fixing this. Maybe we should add some type tests that ensure we don't regress this? Just some fixtures from #1312 and what you used to manually test your changes.

@szmarczak
Copy link
Collaborator Author

I just tested it from #1312. Will add it now.

szmarczak added a commit to jaulz/got that referenced this pull request Jul 6, 2020
@szmarczak
Fix TypeScript types for Promise API (sindresorhus#1344)
972a181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NormalizedOptions incorrect types in Hooks
2 participants
@szmarczak @sindresorhus