Fix response event not being emitted on cache verify request
#1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
reviewed
Jun 5, 2020
szmarczak
reviewed
Jun 5, 2020
szmarczak
reviewed
Jun 6, 2020
This reverts commit f29f9ff.
|
Any thoughts on merging this one? #1287 is pending due to this I think? |
szmarczak
changed the title
response event not being emitted on cache verify request
|
Good job @Giotino! 🙌 |
|
I think this is still not available in |
Yes. I'll try to make another one ASAP. |
szmarczak
pushed a commit
to jaulz/got
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's only a workaround, a real solution is still WIP (this PR will be updated).Checklist
Fixes #1287