check statusCode before parsing body

sindresorhus · Jun 30, 2015 · d30d74a · d30d74a
1 parent a515bfe
commit d30d74a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -180,7 +180,9 @@ function got(url, opts, cb) {
 			readAllStream(res, encoding, function (err, data) {
 				if (err) {
 					err = new GotError('Reading ' + url + ' response failed', err);
-				} else if (data && json) {
+				} else if (json && statusCode !== 204) {
+					// only parse json if the option is enabled, and the response
+					// is not a 204 (empty reponse)
 					try {
 						data = JSON.parse(data);
 					} catch (e) {