-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read permission error on ignore files search #259
Merged
sindresorhus
merged 2 commits into
sindresorhus:main
from
nicolas-goudry:fix/no-read-dir
Feb 11, 2024
Merged
Fix read permission error on ignore files search #259
sindresorhus
merged 2 commits into
sindresorhus:main
from
nicolas-goudry:fix/no-read-dir
Feb 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix #254 with the provided steps to reproduce, would give the following: mkdir someproject
cd someproject
npm init -y && npm i globby
mkdir testdir
chmod -r testdir # remove read access
# Notice the addition of "ignore: ['testdir']" option
node --input-type=module -e "const { globby } = await import('globby'); console.log(await globby('test', { gitignore: true, ignore: ['testdir'] }))" |
@sindresorhus could you please take a look at this? |
azu
added a commit
to secretlint/secretlint
that referenced
this pull request
Feb 17, 2024
- update [email protected] which Fix read permission error on ignore files search refs sindresorhus/globby#259 closes #460
azu
added a commit
to secretlint/secretlint
that referenced
this pull request
Feb 17, 2024
- update [email protected] which Fix read permission error on ignore files search refs sindresorhus/globby#259 closes #460
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #254 and fix #258. As well as
xo
’s #737 whenglobby
’s dependency gets upgraded.It allows to forward the
ignore
option field passed toglobby
’sisIgnoredByIgnoreFiles
tofast-glob
.To give some more context, this function is used to find all
.gitignore
files relative to the current working directory. If any subdirectory of the current working directory is not readable,fast-glob
exits with an error.By forwarding the
ignore
option tofast-glob
when searching for ignore files, we prevent this behavior.A few things that should be considered before this gets merged:
Documentation
There are currently no docs about this, but since the readme file mentions that the
options
object extends thefast-glob
options, I’m not sure if it’s worth to document.Tests
When a directory is not readable, the behavior of
fast-glob
is to exit, not to throw.So, if we remove the
ignore
option of the test,ava
will fail all tests run with the following error:Some side nodes about the test:
.notThrowsAsync
is used, but as said above:fast-glob
doesn’t throw, it exits ; so this might be wrong. You tell me.serial
is used to prevent other tests to fail because of the bad directory permissions.teardown
is used to revert the directory permissions to something readable