Pass deep option to ignore filter to avoid unnecessary recursion #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore.js
Outdated
| @@ -59,12 +59,13 @@ const getIsIgnoredPredicate = (files, cwd) => { | |||
| const normalizeOptions = (options = {}) => ({ | |||
| cwd: toPath(options.cwd) || process.cwd(), | |||
| suppressErrors: Boolean(options.suppressErrors), | |||
| deep: options.deep ? Number.parseInt(options.deep, 10) : Number.POSITIVE_INFINITY, | |||
There was a problem hiding this comment.
The Number.parseInt call seems wrong. The deep option is documented to be a number. If anything, we should throw if it's not a number.
There was a problem hiding this comment.
Yeah, I tend to agree. What would you think about a simple typeof check defaulting to Number.POSITIVE_INFINITY, without throwing? That way, fast-glob remains in charge of validating its own options.
Happy to implement the throwing too, maybe using https://www.npmjs.com/package/@sindresorhus/is?
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When globbing through a very large directory, it's useful to use the
deepoption fromfast-globto stop at a maximum level of depth: https://github.com/mrmlnc/fast-glob#deepHowever when using
gitignore: true, the lookup for ignored files doesn't currently pass thedeepoption, meaning that we still go through every level of the directory.This PR forwards the
deepoption to make it work as expected.