Fix using gitignore
and absolute
options at the same time on Windows
#137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
globby
is invoked withglobby('*', { absolute: true, gitignore: true })
on Windows systems, the assertion added in 4af038e always triggers. This is because when we default thecwd
innormalizeOptions
, we didn't convert fromC:\\
style paths to forward slashes.A simple work around for users hitting this issue, is to provide a
cwd
option that has already been converted:The test added here was failing on Windows, example output prior to the fixes:
Related to #133 (though it isn't clear that this fixes all of the scenarios that #133 is exploring).