Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add globalThis to builtin environment #149

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Add globalThis to builtin environment #149

merged 1 commit into from
Apr 30, 2019

Conversation

bnoordhuis
Copy link
Contributor

It's been available since Node.js v11.0.0.

Refs: nodejs/node#27399

It's also available in (at least) recent Chrome and Firefox but I don't know what your policy is w.r.t. to something that only a subset of browsers support.

@sindresorhus
Copy link
Owner

It's ok to add it, but should be added to builtin, not node.

@bnoordhuis
Copy link
Contributor Author

Okay, updated. Also reworded the commit log.

@sindresorhus sindresorhus changed the title Add globalThis to node environment Add globalThis to builtin environment Apr 30, 2019
@sindresorhus sindresorhus merged commit 53a0bde into sindresorhus:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants