Add support for array of inputs #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### file-icon Swift executable - first and third CLI arguments are treated as comma-separated arrays - if multiple apps are passed as the first CLI argument and the output is written to STDOUT, files are separated by `<EOF>` ### file-icon NodeJS library - Convert all single value inputs into arrays and treat all `file` arguments as an array - fileIcon.buffer returns a `Promise<Buffer>` if `file` is a single value, but will return a `<Promise<Array<Buffer>>` if `file` is an array - Add stricter argument validation with tests - Add tests for all possible use cases and value types with new API - Update ava package to 2.4.0
satazor
approved these changes
Nov 28, 2019
sindresorhus
changed the title
sindresorhus
requested changes
Nov 29, 2019
|
@sindresorhus Thanks for the thorough review! I've been pretty busy these last few days, will try to address / reply to all comments between tomorrow and wednesday. |
- Change all instances of id to ID, pid to PID in test names - Test buffer array lengths - Remove anonymous function usage in `t.throwsAsync` and `t.notThrowsAsync` - Send a single JSON string as CLI argument - Remove PID detection from JS, check in Swift instead (simplify CLI input)
|
@sindresorhus Updated with requested changes |
sindresorhus
requested changes
Dec 23, 2019
- Don't force unwrap, use `if let` instead - Rename input.application to input.appOrPID - Don't use one character variable names - Change `Array<string>` to `string[]` in readme.md
|
@sindresorhus updated! |
|
@sindresorhus Missed that comment. Unfortunately I've been pretty busy and had no real time to dedicate to this issue. I will take a better look, and am planning to pick this up again this weekend. Thank you and sorry for the delay! |
- Use multiple concurrent calls to Swift binary in `buffer` mode - Add pMap as a dependency
|
Is this ready? |
|
If it's ok with you, I would consider this ready, yes :) |
|
Looks great! Thanks for persevering through this. It ended up really well. |
|
Awesome, glad I could help! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
file-icon Swift executable
<EOF>file-icon NodeJS library
filearguments as an arrayPromise<Buffer>iffileis a single value, but will return a<Promise<Array<Buffer>>iffileis an arrayIssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor