Add support for Windows terminals with Unicode fonts #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
force-pushed
the
feat/is-unicode-supported
branch
from
e420d8b
to
37bd303
Compare
👍 |
|
Can you fix the merge conflicts? |
ehmicky
force-pushed
the
feat/is-unicode-supported
branch
from
37bd303
to
a3df660
Compare
|
Rebased 👍 I will rename |
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Windows terminals which support Unicode fonts using
is-unicode-supported.Once this module uses ES modules,
is-unicode-supportedshould be upgraded to the latest version instead of0.1.0.A follow-up question: it seems to me
windowsSymbolsbe renamed tofallbackSymbolsinstead to reflect this change, what do you think?