feat: add new rule no-array-fill-with-reference-type without fix solution #2661

legend80s · 2025-05-29T05:34:59Z

#2657

… imported from ...create-rule.js

…tion

…rray

…nt-docs using Node.js v22.16.0

…eadme.md to main generated by npm run fix:eslint-docs using Node.js v22.16.0

…nt-docs using Node.js v22.16.0

… imported from ...create-rule.js

…tion

…rray

…nt-docs using Node.js v22.16.0

…eadme.md to main generated by npm run fix:eslint-docs using Node.js v22.16.0

…nt-docs using Node.js v22.16.0

…eslint-docs

…e to no mutation to `errors`

legend80s · 2025-10-13T07:07:51Z

Can you fix the merge conflicts?

OK

…emote

legend80s · 2025-10-14T00:39:12Z

@fisker Could you check the CI failures? They don’t appear to be related to this PR.

fisker · 2025-10-16T12:40:09Z

#2782

fisker

I'm having difficulty understanding the logic, will take another look.

rules/no-array-fill-with-reference-type.js

test/string-content.js

rules/no-array-fill-with-reference-type.js

fisker · 2025-10-16T12:55:21Z

Please also take a look at https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/new-rule.md

legend80s · 2025-10-21T01:41:52Z

Please also take a look at https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/new-rule.md

I ran npm run fix:eslint-docs before, but the generated README.md tends to cause merge conflicts, so I suggest the merger run it after this PR is merged.

legend80s · 2025-10-22T09:33:10Z

@fisker Could you check the lint warnings for me. I have merge main but the warnings still exists:
https://github.com/sindresorhus/eslint-plugin-unicorn/actions/runs/18706642494/job/53345855996?pr=2661

rules/no-array-fill-with-reference-type.js

docs/rules/no-array-fill-with-reference-type.md

rules/no-array-fill-with-reference-type.js

…lar case in readme

rules/no-array-fill-with-reference-type.js

…ake the function intent more clearer

…apper2) apart so the code paths are easier to follow

liuchuanzong and others added 30 commits May 29, 2025 09:04

docs: add tips of how to install for new developers

87f000c

fix: error when npm run create-rule > Cannot find package 'lodash-es'…

a8f6d3f

… imported from ...create-rule.js

feat: add new rule no-array-fill-with-reference-type without fix solu…

ea97dd1

…tion

feat(no-array-fill-with-reference-type): only check fill on builtin A…

35057ee

…rray

test(no-array-fill-with-reference-type): add more valid cases

aded9b0

docs(no-array-fill-with-reference-type): remove comments

57f4d74

docs(no-array-fill-with-reference-type): gen code by npm run fix:esli…

85bb03a

…nt-docs using Node.js v22.16.0

docs(no-array-fill-with-reference-type): brief the desc and recover r…

3977224

…eadme.md to main generated by npm run fix:eslint-docs using Node.js v22.16.0

docs: no file configs/recommended.js

8243f14

docs(no-array-fill-with-reference-type): gen code by npm run fix:esli…

3635dd3

…nt-docs using Node.js v22.16.0

docs: add tips of how to install for new developers

fcd690e

fix: error when npm run create-rule > Cannot find package 'lodash-es'…

51af337

… imported from ...create-rule.js

feat: add new rule no-array-fill-with-reference-type without fix solu…

09ca3b5

…tion

feat(no-array-fill-with-reference-type): only check fill on builtin A…

b20ddf2

…rray

test(no-array-fill-with-reference-type): add more valid cases

c70d17f

docs(no-array-fill-with-reference-type): remove comments

7c7fa38

docs(no-array-fill-with-reference-type): gen code by npm run fix:esli…

d3a4179

…nt-docs using Node.js v22.16.0

docs(no-array-fill-with-reference-type): brief the desc and recover r…

681827d

…eadme.md to main generated by npm run fix:eslint-docs using Node.js v22.16.0

docs: no file configs/recommended.js

a6ca789

docs(no-array-fill-with-reference-type): gen code by npm run fix:esli…

2091479

…nt-docs using Node.js v22.16.0

Merge branch 'main' of github.com:legend80s/eslint-plugin-unicorn

d80842c

feat(no-array-fill-with-reference-type): no fixable

90b768b

docs(no-array-fill-with-reference-type): no fixable

a0841ad

feat(no-array-fill-with-reference-type): check Array.from().fill

ab37dcb

docs(no-array-fill-with-reference-type): correct docs

6b14629

docs(no-array-fill-with-reference-type): correct docs by npm run fix:…

b6bf56c

…eslint-docs

test: disable no-array-fill-with-reference-type because it is safe du…

928e51a

…e to no mutation to `errors`

feat: hide unknown type in error message

36b04e3

test: hide unknown type in error message

4f4cf65

test: add a case of hiding unknown type in error message

3813e76

legend80s added 4 commits October 13, 2025 17:49

Merge branch 'main' into main

fc803fc

docs: readme

bb43401

chore(merge): merge remote main and resolve conflicts in readme use r…

a6d394c

…emote

chore(merge): merge remote main and resolve conflicts in readme use r…

6bf07d3

…emote

fisker requested changes Oct 16, 2025

View reviewed changes

style: format importings and remove useless debugging code

f15bb32

legend80s requested a review from fisker October 21, 2025 01:43

legend80s added 2 commits October 21, 2025 17:39

refactor: remove useless logs

bb92e95

Merge branch 'sindresorhus:main' into main

6d7106c

fisker reviewed Oct 22, 2025

View reviewed changes

rules/no-array-fill-with-reference-type.js Outdated Show resolved Hide resolved

fisker reviewed Oct 22, 2025

View reviewed changes

docs/rules/no-array-fill-with-reference-type.md Outdated Show resolved Hide resolved

fisker reviewed Oct 22, 2025

View reviewed changes

rules/no-array-fill-with-reference-type.js Outdated Show resolved Hide resolved

legend80s added 4 commits October 24, 2025 13:55

refactor: rename function name to clear ambiguousness and remove simi…

2063c39

…lar case in readme

Merge branch 'main' of github.com:legend80s/eslint-plugin-unicorn

38454c3

refactor: make code intent more obvious

4990e6b

refactor: make declaredInCurrentFunction more readable

8dd83fa

fisker reviewed Oct 24, 2025

View reviewed changes

rules/no-array-fill-with-reference-type.js Outdated Show resolved Hide resolved

fisker reviewed Oct 24, 2025

View reviewed changes

rules/no-array-fill-with-reference-type.js Outdated Show resolved Hide resolved

fisker reviewed Oct 24, 2025

View reviewed changes

rules/no-array-fill-with-reference-type.js Show resolved Hide resolved

legend80s added 5 commits October 27, 2025 08:58

refactor: simplify return value of isReferenceType and rename it to m…

f5348df

…ake the function intent more clearer

refactor: rename function and argument name

8c95017

refactor: clarify comment

16b9e9a

refactor: split Array.from(arrayLike, mapper1) and Array.from().map(m…

9e2b96e

…apper2) apart so the code paths are easier to follow

fix: fix eslint errors

7abbdce

Uh oh!

feat: add new rule no-array-fill-with-reference-type without fix solution #2661

Are you sure you want to change the base?

feat: add new rule no-array-fill-with-reference-type without fix solution #2661

Uh oh!

Conversation

legend80s commented May 29, 2025

Uh oh!

legend80s commented Oct 13, 2025

Uh oh!

legend80s commented Oct 14, 2025

Uh oh!

fisker commented Oct 16, 2025

Uh oh!

fisker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fisker commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legend80s commented Oct 21, 2025

Uh oh!

legend80s commented Oct 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fisker commented Oct 16, 2025 •

edited

Loading