Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependency on lodash #2184

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Remove direct dependency on lodash #2184

merged 3 commits into from
Oct 29, 2023

Conversation

ArnaudBarre
Copy link
Contributor

Hi! Thanks for the great plugin. I'm trying to reduce to install size of my default setup, and I noticed that this plugin pulls the lodash package which 5 MB, half of the install size of the plugin.

Because there is some complex logic around non-ascii for upperFirst & co, I decided to go with bundling only the require methods (expect pick where the change avoid an extra spread).

I've not measured it, but I think it could impact boot time for eslint because of the total quantity of JS for the whole loadash package.

@sindresorhus sindresorhus merged commit 54da9ca into sindresorhus:main Oct 29, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants