require-array-join-separator: Mention what the default join behavior is
#1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
approved these changes
May 18, 2021
sindresorhus
changed the title
array-join-separator: mention what the default join behavior isarray-join-separator: Mention what the default join behavior is
fisker
approved these changes
May 19, 2021
…avoid Naturally, I think readers will be curious what the default behavior of `join` when this rule is not followed.
fisker
changed the title
array-join-separator: Mention what the default join behavior isrequire-array-join-separator: Mention what the default join behavior is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naturally, I think readers will be curious what the default separator behavior of
joinis when this rule is not followed.Alternatively, we could just mention it on the example: