feat: improve rule id to always align to right of terminal #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t line of message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatter-pretty can show a really nasty looking report if just 1 message exceeds or comes close to exceeding the width of the terminal
The solution below changes the alignment of the ruleId from:
current state: rule ids are aligned at the left most letter, and can line break in middle of the rule id. If any message exceeds the width of the terminal the rule id can end up in strange places for all errors reported usually with a few lines of separation.
PR state: rule ids are always right aligned. If a message exceeds the terminal width, the rule id is right aligned on the last line of the message or the following line depending on how much space it has and things look much better in many difference scenarios.