Add support for different Opera browsers #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Then the regex should be fixed. |
windows.js
Outdated
| @@ -15,6 +15,10 @@ const windowsBrowserProgIds = { | |||
| BraveHTML: {name: 'Brave', id: 'com.brave.Browser'}, | |||
| BraveBHTML: {name: 'Brave Beta', id: 'com.brave.Browser.beta'}, | |||
| BraveSSHTM: {name: 'Brave Nightly', id: 'com.brave.Browser.nightly'}, | |||
| Opera: {name: 'Opera GX', id: 'com.operasoftware.operagx'}, | |||
| OperaStable: {name: 'Opera', id: 'com.operasoftware.opera'}, | |||
There was a problem hiding this comment.
Would be better to use the ID as used on macOS.
There was a problem hiding this comment.
Not sure if I got them right, I use Windows and I'm not very familiar with macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a different set of Opera browsers.
ProgId of Opera GX is added as just "Opera" within windowsBrowserProgIds object due to the matching regex not supporting whitespaces, since the Windows ProgId is "Opera GXStable", therefore the matching returns just Opera. This just happens with Opera GX, other browsers don't have spaces.