Support ad blocking

[jopemachine]

Fixes #7.

I think we could use @cliqz/adblocker-puppeteer package to support ad blocking.

Notes

• This draft PR does not include the option representing whether to use the ad-blocker, related option, type, tests and documentations yet.

• If I'm on the right way, I'd appreciate it if you could let me know. Then I will try to do the next works.

[sindresorhus]

Yes, this looks like the right path.

What do you think about making ad-blocking opt-out instead of opt-in?

[jopemachine]

Yes, this looks like the right path.

What do you think about making ad-blocking opt-out instead of opt-in?

In my opinion, opt-out would be better. I think there are likely to be more users who do not need ads in their screenshots than those who do not.

[sindresorhus]

Opt-out it is then.

[jopemachine]

@sindresorhus I've been thinking about the unit testing of this flag.
Do I need to compare generated screenshot having an ad with the one without the ad? (It seems that using resemble.js is one way to do this)
Would it be there some better methods to test blockAds option?

[sindresorhus]

I think manually verifying it works is enough. A unit test will fail at some point when ads or ad blocker changes.

[jopemachine]

I think manually verifying it works is enough. A unit test will fail at some point when ads or ad blocker changes.

Ok, I just made this Draft PR ready. Please let me know if there are other things for me to do :)

[sindresorhus]

Doesn't look like you updated the TS types.

[sindresorhus]

Thanks :)

Would you be able to add a --no-block-ads flag to the CLI?

[jopemachine]

Thanks :)

Would you be able to add a --no-block-ads flag to the CLI?

Sure, I'll make a PR to CLI module as soon as capture-website's next version is released :)

[sindresorhus]

https://github.com/sindresorhus/capture-website/releases/tag/v2.3.0