-
-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update link for "Drupal" CMS #3299
base: main
Are you sure you want to change the base?
Conversation
The link for Drupal CMS links to an outdated, unmaintained repository. Replacing with an active one. Related issues: - theodorosploumis/awesome-drupal#1 - nirgn975/awesome-drupal#15
The linting Action need to run again. But it is not correct to just add an extra commit on the repository to trigger this again. |
Cooking Good 👍 |
Looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I've seen that you've put an issue to the original list owner but no pull request – unclear on the guidelines as to when exactly an unmaintained list should be removed. Maybe try a PR to see if they respond? I would agree that inactive lists where the owner and contributors aren't maintaining them should be replaced. Would like to see more descriptions on the entries for your list as they're all links at the moment and the context isn't clear from the some of the titles. Linting changes look good though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your PR itself looks fine to me. Some comments on the list:
I like that you didn't include inactive projects like Hedley, which are still on the inactive list.
What strikes me as odd is that your list has very little resemblance and only a few common items with the existing list.
Is everything that was awesome eight years ago deprecated now?
Section drupal.org
seems to me like a site map of their web page. On the bottom, there's a list of twitter accounts of th different regions. Not sure, why they'd be "awesome".
- IMHO you should definitely prune your list and make it more opinionated.
- Also, I second @hazzah3 that your list is missing explanations. The inactive list has some, maybe copy is possible
Here are a few things I've spotted while reviewing:
|
Tasks that could probably improve the list:
|
@theodorosploumis Can't argue, if it's your opinion that the list is opinionated :D Hope you didn't take anything personally, I simply follow Antoine de Saint-Exupéry: “Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away.” I'm not an expert on Drupal, maybe you can educate me a little:
|
https://github.com/theodorosploumis/awesome-drupal
The link for Drupal CMS links to an outdated, unmaintained repository.
Replacing with an active one.
Related issues:
My Pull Requests Reviews:
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.