-
-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add awesome-game-analysis #2729
Conversation
For this requirement, can you add links to the 2 reviews you've made?
You can see an example of how and where to add your links from this PR. |
Updated. |
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
here's my awesome-lint output, the remainder of the errors is double links, but I want to quickly reference articles of relative games so I put these comparison articles (Game A vs Game B) in both game entries. |
|
Thanks for your kind reminder! |
You will have to be patient and wait those 30 days! In the mean time your logo is 404 and the title should not have 'awesome' in it |
I believe that your PR title is incorrect, it should not contain the word "awesome" and should be in title case. |
The list is looking good! Just a suggestion: it would be great to include a game genre column as well. |
Bump |
Items in the "References" section are missing descriptions. |
This apply to all lists. |
c05ec08
to
bbe1e6f
Compare
Closing for lack of response. |
https://github.com/OTFCG/Awesome-Game-Analysis
a repository dedicated to the collection and analysis of various games, including graphics breakdown, frame analysis, gameplay design, networking and anything about game development (much focus on the programming side).
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Other PR's Reviewed prior to this PR:
add official docker awesome-compose #2692
Add Processing #2524
You have read and understood the instructions for creating a list.
This pull request has a title in the format
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Your entry should be added at the bottom of the appropriate category.
The title of your entry should be title-cased and the URL to your list should end in
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
No blockchain-related lists.
The suggested Awesome list complies with the below requirements.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
(we use the toml format data for generation workflow and friendly change submission and for convinient of our future production)
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.(We only have a few headlines, so we don't need them)
https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.