-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Algorand #2165
Add Algorand #2165
Conversation
Adds reference to Algorand themed awesome list. Maintained by community developers and solution architects from Algorand.
@sindresorhus sorry for disabling some of the warning on the linter here are the explanations on why those are disabled:
Hopefully this justifies it sufficiently. let me know if u still need me to tweak something. And thanks for maintaining this initiative - awesome work! |
Thanks for making an Awesome list! π It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
@sindresorhus thanks for pointing this out - will go over the requirements once again, address them and ping you back once ready for next review round |
@sindresorhus ready for another review, sorry for not addressing those before opening the PR. See above PR reference for detailed list of changes applied on main branch to further comply with requirements. Here is a recap:
The only remaining awesome lint rule which is manually silenced is: Hopefully that should be sufficient, let me know what you think |
|
Unicorn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that unicorn keyword does anything, but I advise to run awesome-lint on your own repo to ensure you are compliant with awesome guidelines, see sindresorhus/awesome-lint
Thanks for the comment. Please check the comments I left above - I appended a detailed list of changes I applied in addition to just awesome lint suggestions (as required in the pr). My repo does run awesomen lint via GitHub actions on each pr review. The only disabled warning is the repo age which I will reactivate this Thursday (will be exactly 30 days). @sindresorhus would really appreciate you taking a look again. If there are still items that you think require addressing I'd appreciate a bit more detailed description on what's not compliant. |
Sorry I didn't notice in your comment that you have already run awesome-lint. |
@abenhamdine to be exact here is the PR im keeping till Thursday and merging once awesome-lint is passing 30 day age limit https://github.com/aorumbayev/awesome-algorand/pull/36/files. You can indeed see that the only warning I disabled is the
if you want to verify linter is passing. Otherwise, if this looks ok to you - can I expect this to be merged some time this week? |
One more fyi, just merged the pr that removes the last silenced awesome-lint warning |
|
Just wanted to follow up to see if there are any additional items needed to be addressed or we can proceed with merging. |
Adds reference to Algorand themed awesome list. Maintained by community developers and solution architects from Algorand.
Awesome Algorand
An awesome list created for Algorand Blockchain development community. References and aggregates all known Algorand related resources useful for development or getting familiar with the ecosystem of tools. Actively maintained by community and several engineers from Algorand.
By submitting this pull request I confirm I've read and complied with the below requirements π
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting βlooks goodβ or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](β¦) - Mobile operating system for Apple phones and tablets.
- [Framer](β¦) - Prototyping interactive UI designs.
- [iOS](β¦) - Resources and tools for iOS development.
- [Framer](β¦)
- [Framer](β¦) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](β¦) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.