-
-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hive #1817
Add Hive #1817
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
unicorn |
@sindresorhus I am not sure if anything else is missing. If you would kindly mention or give direction, would be grateful! Thanks! |
https://github.com/morenoh149/awesome-outsourcing The business practice of hiring a party outside a company to perform services and create goods. It should be added because it provides valuable information if you are thinking about outsourcing software development. Where do you start, how does this process work, etc. I reviewed sindresorhus#1817 , sindresorhus#1816 and sindresorhus#1813 . I confirm I've read and complied with the awesome requirements (I made a new pr because I accidentally deleted the first fork, re sindresorhus#1825)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that this project is released with a Code of Conduct.
You addressed code of conduct in contribution guidelines, but it looks like the conduct file doesn't exist https://github.com/ledgerconnect/awesome-hive/blob/master/code-of-conduct.md
Also
The default branch should be named main, not master.
You can follow the steps here.
@mhxion Thank you, I did fix above mentioned issues! @sindresorhus Please have a look again, when you get a chance, Thanks! |
My direction is to go through each item and ensure you're following them. |
Thanks, should be all set! |
Descriptions should not be title-cased.
|
Updated! |
You have not addressed all the comments. |
Is it referring to description of this PR? #1817 (comment) |
This is the description in PR issue on github as well as in readme of awesome. I have updated description of awesome-hive list as well to be lowercase. Could you please re-check? |
^ I don't know how to make this clearer. There are even examples in the guidelines.
You have not. |
I'm going to pass on this list. |
Ok let me go through everything again and will open new PR, would that be ok?! |
https://github.com/ecency/awesome-hive#readme
Powerful blockchain for social, gaming, financial dapps.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Reviewed: #1175 and #1770
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.unicorn
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.