Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awesome-list-item Bug with selection of link to validate #199

Open
sancarn opened this issue Aug 15, 2024 · 1 comment
Open

awesome-list-item Bug with selection of link to validate #199

sancarn opened this issue Aug 15, 2024 · 1 comment

Comments

@sancarn
Copy link

sancarn commented Aug 15, 2024

Please see awesome-vba. We use symbology to indicate various things from OS compatibility to application compatibility among other things. This provides users with up-front knowledge as to what they are signing up to when using such a library. If a user is using e.g. a mac they can search specifically for libraries compatible on mac etc.

I think this symbology would be useful in other awesome lists, but I feel it is required in the case of VBA.

@sancarn sancarn changed the title Allowing symbology would be useful awesome-list-item Bug with selection of link to validate Aug 26, 2024
@sancarn
Copy link
Author

sancarn commented Aug 26, 2024

We have identified the source of the issue and are upgrading this to a Bug as this is really from a poor algorithm of determining where the title should be.

Existing algorithm:

// Might have children like: '{image} {text} {link} { - description}'
// Keep discarding prefix elements until we find something link-like.
while (link.type !== 'linkReference' && link.type !== 'link' && description.length > 1) {
	link = description[0];
	description = description.slice(1);
}

In my opinion the key here isn't that there is something link-like but rather that it is prefixed by -.

sancarn added a commit to sancarn/fork-awesome-lint that referenced this issue Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant