This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Unpublish banner image #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is adding 1.6 MBs to the package's filesize, which is too large for a purely presentational asset. Ideally, we'd use an `.npmignore` file to exclude the image from release tarballs, but APM lacks support for this.
|
You could use .gitattributes to ignore files during publication. |
|
@gorriecoe That only works for |
|
@Alhadis This works. I have used the same approach in https://github.com/gorriecoe/atom-silverstripe. |
|
Well, I'll be fucked... it does too. Quite happy to have been proven wrong. Makes me wonder why the hell we even need |
This was referenced Nov 12, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix to improve the package's filesize (shaving off ~1.6 MBs). Basically, this image is now being loaded from a specific commit, instead of the master branch:
Ideally, we'd be using
.npmignoreto exclude the image from publication, but Atom's package manager has no support for this feature... so whatever the branch holds at the time of release is what gets tarballed.