Skip to content

Commit

Permalink
Fix green line sometimes occurring on the GIF (#278)
Browse files Browse the repository at this point in the history
  • Loading branch information
sindresorhus authored Aug 8, 2022
1 parent ad9cfcd commit 6479e7c
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions Gifski/Gifski.swift
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,7 @@ final class Gifski {
generator.requestedTimeToleranceBefore = .zero
generator.requestedTimeToleranceAfter = .zero

// This improves the performance a little bit.
if let dimensions = conversion.dimensions {
generator.maximumSize = CGSize(widthHeight: dimensions.longestSide)
}
// We are intentionally not setting a `generator.maximumSize` as it's buggy: https://github.com/sindresorhus/Gifski/pull/278

// Even though we enforce a minimum of 3 FPS in the GUI, a source video could have lower FPS, and we should allow that.
var fps = (conversion.frameRate.map(Double.init) ?? assetFrameRate).clamped(to: 0.1...Constants.allowedFrameRate.upperBound)
Expand Down

0 comments on commit 6479e7c

Please sign in to comment.