JSX style is unreadable and too dark

[dbkaplun]

Code in question

[simurai]

@dbkaplun Thanks for example code and screenshot.. that's very helpful.

Just another question: What's the language package you are using? I can see the grammar as `JavaScript (JSX).

[dbkaplun]

I'm using [email protected], is that what you mean? That's the only package I see when I search for "jsx" in the Packages tab of Settings. Maybe it's built-in?

[simurai]

[email protected] shouldn't do syntax highlighting. Do you have https://atom.io/packages/language-babel. It has jsx support and is quite popular.

[dbkaplun]

I have package [email protected], maybe that's it? It's way too dark with .js as well. I'll attach a screenshot when I get the chance.

[simurai]

Yes, react is probably it. I'll try it out with your sample code and see why it's so dark.

[dbkaplun]

Here's some nice dark JS code

[simurai]

Ok, this should be improved with #21 and published as 2.0.1.

[dbkaplun]

Definitely looks a little better, still very dark though (specifically punctuation and builtins like moveTo and Math.sin). Even linesCtx is very dark. It's a shame because this is my favorite theme and I hate having to use other themes. Should I open another issue? Looks like your Atom is significantly redder than mine.. on your screen, beginPath is white and on mine it's lavender. Maybe that has something to do with it?

[simurai]

Looks like your Atom is significantly redder than mine.. on your screen, beginPath is white and on mine it's lavender. Maybe that has something to do with it?

In DuoTone dark you can now change the colors in the settings, see: https://github.com/simurai/duotone-dark-syntax#settings So you could brighten everything.

I'll see about brightening the default since that seems a bit dark.