improvement(performance): remove unused source/target indices, add index on snapshot id

[waleedlatif1]

Summary

• remove unused source/target indices
• add index on snapshot id

Type of Change

• Other: Performance

Testing

Tested manually/

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Oct 11, 2025 6:22pm
sim	Skipped			Oct 11, 2025 6:22pm

[greptile-apps]

Greptile Overview

Summary

This PR optimizes database indices for the workflow_edges and workflow_execution_logs tables.

Changes:

• Removes redundant single-column indices workflow_edges_source_block_idx and workflow_edges_target_block_idx from the workflow_edges table. These indices are unnecessary because all queries filter by workflowId first, making the existing composite indices workflow_edges_workflow_source_idx (on workflowId, sourceBlockId) and workflow_edges_workflow_target_idx (on workflowId, targetBlockId) sufficient and more efficient.
• Adds workflow_execution_logs_state_snapshot_id_idx on workflow_execution_logs.state_snapshot_id. This index optimizes join queries between workflow_execution_logs and workflow_execution_snapshots tables, which are used in multiple API endpoints to fetch execution state data.

The migration correctly synchronizes the SQL changes with the schema definition.

Confidence Score: 5/5

• This PR is safe to merge with no risk
• The changes are well-justified performance optimizations. The removed indices are redundant because all workflow_edges queries filter by workflowId first, making composite indices more effective. The added stateSnapshotId index directly addresses a real query pattern (joins with workflow_execution_snapshots) found in multiple API routes. The migration is properly structured and synchronized with the schema.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
packages/db/migrations/0098_thick_prima.sql	5/5	Drops unused single-column indices on workflow_edges and adds new index on workflow_execution_logs.state_snapshot_id for join queries
packages/db/schema.ts	5/5	Removes redundant single-column indices from workflowEdges table and adds stateSnapshotIdIdx to workflowExecutionLogs table

Sequence Diagram

sequenceDiagram
    participant API as API Route
    participant DB as Database
    participant WEL as workflow_execution_logs
    participant WES as workflow_execution_snapshots
    participant WE as workflow_edges

    Note over WE: Before: Had redundant indices<br/>source_block_idx, target_block_idx
    Note over WE: After: Only composite indices<br/>workflow_source_idx, workflow_target_idx

    API->>DB: Query workflow edges
    DB->>WE: SELECT * WHERE workflowId = ?
    Note over WE: Uses workflow_id_idx<br/>(composite indices cover<br/>source/target filtering)
    WE-->>DB: Return edges
    DB-->>API: Edges data

    API->>DB: Query execution logs with state
    DB->>WEL: SELECT * WHERE executionId = ?
    WEL-->>DB: Return log with stateSnapshotId
    
    Note over WEL: New index added:<br/>state_snapshot_id_idx
    
    DB->>WES: SELECT * WHERE id = stateSnapshotId
    Note over WES: Join optimized by new index
    WES-->>DB: Return snapshot data
    DB-->>API: Complete execution data

Loading

_{4 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[elviromercic23-cmyk]

Wow perfect sub, 11. lis 2025. 20:29 Waleed ***@***.***> je napisao:

…

Merged #1603 <#1603> into staging. — Reply to this email directly, view it on GitHub <#1603 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BU4CU7J3H3T2WRRX5TGJQYL3XFD7BAVCNFSM6AAAAACI5TKOTCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRQGIZDMNJZG44TCOI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>