Skip to content

Conversation

@Anil567849
Copy link

Summary

This PR consolidates previous modal fixes to address:

  • Horizontal overflow caused by long unbroken search strings
  • Alignment issues for the "No results found" message

Type of Change

  • Bug fix

Testing

  • Manually tested with very long unbroken search queries
  • Verified that text wraps correctly (break-all) and vertical scroll (overflow-y) works
  • Checked alignment remains centered

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Before: Long string overflowed horizontally, misaligned.
image

After: Text wraps correctly, vertically scrollable, perfectly centered, lint passes.
image

@vercel
Copy link

vercel bot commented Sep 9, 2025

@Anil567849 is attempting to deploy a commit to the Sim Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes UI issues in the search modal's empty state component by addressing horizontal overflow and text alignment problems. The changes are made to the "No results found" message display in apps/sim/app/workspace/[workspaceId]/w/components/search-modal/search-modal.tsx.

The fix involves two key changes to the empty state container:

  1. Padding adjustment: Changed from ml-6 (margin-left only) to px-6 (horizontal padding) to ensure proper spacing on both sides of the text
  2. Word breaking: Added break-all class to force long unbroken strings to wrap to new lines instead of causing horizontal overflow

This addresses a specific user experience issue where very long search queries (such as URLs or extremely long words without spaces) would cause the modal content to overflow horizontally beyond the modal boundaries. The solution maintains the centered text alignment while ensuring all content remains contained within the modal's viewport. The changes integrate seamlessly with the existing Tailwind CSS styling system used throughout the Sim application and follow the component's established styling patterns.

Confidence score: 5/5

  • This PR is extremely safe to merge with virtually no risk of breaking existing functionality
  • Score reflects simple, focused CSS changes that only affect visual presentation without touching any business logic or data handling
  • No files require special attention - the changes are minimal and well-contained to a single UI component

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@Anil567849
Copy link
Author

Anil567849 commented Sep 9, 2025

Hi 👋, I’ve fixed the linting issue reported earlier.
The build now passes all checks ✅.
Please let me know if anything else is needed. Thanks

@Anil567849
Copy link
Author

Hi @waleedlatif1 , just wanted to kindly follow up on this PR. It’s now passing all checks ✅. Please let me know if you’d like any further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant