New lightgrep #486
Open
New lightgrep #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmance regression. The timings below are from the following command: ./src/bulk_extractor -F ../lightgrep/pytest/keys/shuf10.txt -Z -o ~/be_timed_output_without_thread_local_`printf %04d $i` -E scan_lightgrep ~/ev/terry-2009-12-11-002.E01 Thread_local? Clocktime (Min.) Clocktime (Max.) Clocktime (Average) Scan Lightgrep Time (Min.) Scan Lightgrep Time (Max.) Scan Lightgrep Time (Average) FALSE 162.965479 168.628229 164.2545712 494.810946 528.368114 504.1799554 TRUE 163.681386 173.587754 167.233617 499.815450 532.324335 516.4901762 This reverts commit 0ca43ec.
Update lightgrep scanner for bulk_extractor 2.0
|
Ah, with the build failure, I don't think we tried running |
|
The most significant thing that's changed is we now have a full release of lightgrep v1.5, available here: https://github.com/strozfriedberg/lightgrep/releases/tag/1.5.0 We can change @simsong I would appreciate it if you could look at the diff for scan_lightgrep.cpp, as the typical scanner setup and usage is what I'm most unsure of. |
|
Yay!----Sent from my phone.On Feb 11, 2025, at 9:55 PM, Jon Stewart ***@***.***> wrote:
Ah, with the build failure, I don't think we tried running make distdir-am, probably just plain old make. Nice to have automated tests!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Sure. I will review in the next day or so.Generally, I don't review draft PRs. I missed when you tagged me. And the top of the PR said it wasn’t ready for review…----Sent from my phone.On Feb 11, 2025, at 10:05 PM, Jon Stewart ***@***.***> wrote:
The most significant thing that's changed is we now have a full release of lightgrep v1.5, available here: https://github.com/strozfriedberg/lightgrep/releases/tag/1.5.0
We can change Makefile.am to fix the distdir-am target and whatever comes afterwards. We'll also adjust the CONFIGURE_ scripts to pull lightgrep v1.5.0 from the above URL. With the CONFIGURE_ scripts, is there some way to add commonality to all of them?
@simsong I would appreciate it if you could look at the diff for scan_lightgrep.cpp, as the typical scanner setup and usage is what I'm most unsure of.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now let's see this run in GitHub Actions