Skip to content

Pass Socket.IO instance instead of the http server #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Pass Socket.IO instance instead of the http server #112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce75f86
Pass Socket.IO instance instead of the http server
sanrodari Sep 19, 2017
f6b16f2
Fix clientsInRoom function
sanrodari Sep 19, 2017
aea70bc
Fix for Socket.IO v2
sanrodari Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions sockets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ var socketIO = require('socket.io'),
uuid = require('node-uuid'),
crypto = require('crypto');

module.exports = function (server, config) {
var io = socketIO.listen(server);

module.exports = function (io, config) {
io.sockets.on('connection', function (client) {
client.resources = {
screen: false,
Expand Down Expand Up @@ -126,7 +124,7 @@ module.exports = function (server, config) {

function describeRoom(name) {
var adapter = io.nsps['/'].adapter;
var clients = adapter.rooms[name] || {};
var clients = io.nsps['/'].connected || {};
var result = {
clients: {}
};
Expand All @@ -137,7 +135,7 @@ module.exports = function (server, config) {
}

function clientsInRoom(name) {
return io.sockets.clients(name).length;
return Object.keys(io.nsps['/'].adapter.rooms[name] || {}).length;
}

};
Expand Down