Skip to content

Disable formatting on signed elements #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Disable formatting on signed elements #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/XML/SignedElementTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ public function getSignature(): ?Signature
*/
protected function setSignature(Signature $signature): void
{
/**
* By disabling formatting on signed objects, we prevent issues with invalid signatures later on
* at the cost of some whitespace taking up useless bytes in the outputted document.
*/
$this->formatOutput = false;
$this->signature = $signature;
}

Expand Down