I accidentally removed a prior pr when updating from upstream.

simplecastapps · Feb 7, 2024 · 5ea733f · 5ea733f
1 parent a04ab68
commit 5ea733f
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 19 deletions.
diff --git a/regexes/bots.yml b/regexes/bots.yml
@@ -1540,6 +1540,14 @@
   category: 'Feed Reader'
   url: 'https://theoldreader.com'
 
+- regex: 'Trackable/0.1'
+  name: 'Chartable'
+  category: 'Site Monitor'
+  url: 'https://help.chartable.com/article/34-what-is-the-trackable-analytics-prefix'
+  producer:
+    name: 'Chartable'
+    url: 'https://chartable.com'
+
 - regex: 'trendictionbot'
   name: 'Trendiction Bot'
   category: 'Crawler'

diff --git a/regexes/client/mobile_apps.yml b/regexes/client/mobile_apps.yml
@@ -2182,11 +2182,6 @@
   name: 'NPR'
   version: '$1'
 
-# unsure what this is, but is used quite a bit
-- regex: 'Trackable/([\d\.]+)'
-  name: 'Trackable'
-  version: '$1'
-
 - regex: 'Uforia/([\d\.]+)'
   name: 'Uforia'
   version: '$1'
@@ -2195,7 +2190,7 @@
   name: 'L.A. Times'
   version: ''
 
-- regex: '(?:^NYT(?: |%20)?Audio|nytios)/([\d.]+)'
+- regex: '(?:^NYT(?: |%20)?Audio(?:-iOS)?|nytios)/([\d.]+)'
   name: 'The New York Times'
   version: '$1'
 

diff --git a/tests/data/fixtures/bots.yml b/tests/data/fixtures/bots.yml
@@ -5833,6 +5833,15 @@
     name: phpMyAdmin
     category: Service Agent
     url: https://www.phpmyadmin.net/
+-
+  user_agent: Trackable/0.1 NNjCeA
+  bot:
+    name: Chartable
+    category: Site Monitor
+    url: "https://help.chartable.com/article/34-what-is-the-trackable-analytics-prefix"
+    producer:
+      name: 'Chartable'
+      url: 'https://chartable.com'
 -
   user_agent: Matomo/4.15.1
   bot:

diff --git a/tests/data/fixtures/podcasting.yml b/tests/data/fixtures/podcasting.yml
@@ -1396,6 +1396,22 @@
     model: ''
   os_family: Unknown
   browser_family: Unknown
+-
+  user_agent: 'Spotify/120800923 OSX/0 (MacBookPro6,2)'
+  os:
+    name: Mac
+    version: ""
+    platform: ""
+  client:
+    type: mobile app
+    name: Spotify
+    version: "120800923"
+  device:
+    type: "desktop"
+    brand: "Apple"
+    model: 'MacBook Pro 15" (2010)'
+  os_family: Mac
+  browser_family: Unknown
 -
   user_agent: 'AmazonMusic'
   os: [ ]
@@ -8883,19 +8899,6 @@
     model: ''
   os_family: iOS
   browser_family: Unknown
--
-  user_agent: 'Trackable/0.1 NNjCeA'
-  os: [ ]
-  client:
-    type: mobile app
-    name: Trackable
-    version: "0.1"
-  device:
-    type: ""
-    brand: ""
-    model: ''
-  os_family: Unknown
-  browser_family: Unknown
 -
   user_agent: 'Uforia/1056 CFNetwork/1406.0.4 Darwin/22.4.0'
   os: