convert scripts to esm #6946
Merged
convert scripts to esm #6946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinraja
commented
Dec 4, 2021
LitoMore
reviewed
Dec 4, 2021
Co-authored-by: LitoMore <[email protected]>
LitoMore
reviewed
Dec 4, 2021
mondeja
reviewed
Dec 10, 2021
There was a problem hiding this comment.
Awesome!
Would you mind to update the new script scripts/release/update-svgs-count.js introduced by #6951 @sachinraja?
Additionally, I think that we should wait to te new major version release of SVGLint to do not mix different JS syntaxes in the project, but I'm not totally against it if this takes a long time.
|
Personally, I don't mind mixing the two, especially since it's only for two files, but I'm ok with waiting. |
mondeja
added
meta
LitoMore
reviewed
Dec 24, 2021
LitoMore
reviewed
Dec 24, 2021
mondeja
requested changes
Dec 24, 2021
LitoMore
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the script files to esm. This includes all files under the
scriptsandtestsdirs.