-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor base class #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapped function could support them after all.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 91.71% 99.62% +7.91%
==========================================
Files 7 7
Lines 374 531 +157
==========================================
+ Hits 343 529 +186
+ Misses 31 2 -29 ☔ View full report in Codecov by Sentry. |
jcapriot
force-pushed
the
consistent_refactor
branch
5 times, most recently
from
October 10, 2024 20:02
54156ff
to
fbfa8ff
Compare
jcapriot
force-pushed
the
consistent_refactor
branch
3 times, most recently
from
October 10, 2024 20:15
c57f2eb
to
860858c
Compare
jcapriot
force-pushed
the
consistent_refactor
branch
from
October 10, 2024 20:18
860858c
to
5047329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is aimed at increasing consistency throughout the package, adding a few bits of missing information.
set_kwargs
funciton.np.linalg.solve
.Forward
andBackward
class (and makes them transposes of each other).solver.transpose()
method, which is aliased as a property assolver.T
.Base
as an abstract class, where subclasses must implement a_solver_single
and a_solve_multiple
.rtol
andatol
keywords for solution checking.__matmul__
,__rmatmul__
, and__rmul__
operations.