Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #46

Merged
merged 18 commits into from
Aug 20, 2024
Merged

Fix CI #46

merged 18 commits into from
Aug 20, 2024

Conversation

mplough-kobold
Copy link
Contributor

@mplough-kobold mplough-kobold commented Aug 16, 2024

This PR gets CI passing on all platforms.

  • Action versions have been upgraded.
    • conda-incubator/setup-miniconda@v3. Version 3.0.4 of that action addresses the issue that runners no longer provide miniconda by default.
    • actions/checkout@v4, codecov/codecov-action@v4. Version 2 ran on node.js 12 which is no longer available in GitHub Actions.
  • Python 3.7 is dropped and the minimum version of scipy is bumped to 1.8. This matches SimPEG's supported versions. I also added CI runs on Python 3.11, which pass nicely with no special modifications.
  • MacOS runners are constrained to macOS-13. The macOS-latest runner is now Apple Silicon, which means that the pardiso solver can no longer be used on those runners. We'll want to get MUMPS working for macOS eventually; that effort is already in progress over in Add mumps solver #43.
  • packaging is added as a dependency so we can check which version of scipy is in use; this allows the BicgJacobi iterative solver to be compatible with versions of scipy that include the old tol and new rtol kwarg names.

Fixes #45.

@mplough-kobold mplough-kobold marked this pull request as draft August 19, 2024 13:39
@mplough-kobold mplough-kobold changed the title Fix CI on macOS Fix CI Aug 19, 2024
@mplough-kobold mplough-kobold marked this pull request as ready for review August 19, 2024 15:31
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (3eedc9d) to head (d79d979).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   89.26%   89.36%   +0.10%     
==========================================
  Files           5        5              
  Lines         298      301       +3     
==========================================
+ Hits          266      269       +3     
  Misses         32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot jcapriot merged commit b0b3018 into simpeg:main Aug 20, 2024
15 checks passed
@mplough-kobold mplough-kobold deleted the matt-fix-macos-tests branch October 2, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests failing / not running
2 participants