-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #46
Merged
Merged
Fix CI #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/home/runner/work/pymatsolver/pymatsolver/pymatsolver/iterative.py:26: DeprecationWarning: Please import `aslinearoperator` from the `scipy.sparse.linalg` namespace; the `scipy.sparse.linalg.interface` namespace is deprecated and will be removed in SciPy 2.0.0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 89.26% 89.36% +0.10%
==========================================
Files 5 5
Lines 298 301 +3
==========================================
+ Hits 266 269 +3
Misses 32 32 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets CI passing on all platforms.
conda-incubator/setup-miniconda@v3
. Version 3.0.4 of that action addresses the issue that runners no longer provide miniconda by default.actions/checkout@v4
,codecov/codecov-action@v4
. Version 2 ran on node.js 12 which is no longer available in GitHub Actions.macOS-13
. ThemacOS-latest
runner is now Apple Silicon, which means that the pardiso solver can no longer be used on those runners. We'll want to get MUMPS working for macOS eventually; that effort is already in progress over in Add mumps solver #43.packaging
is added as a dependency so we can check which version ofscipy
is in use; this allows theBicgJacobi
iterative solver to be compatible with versions of scipy that include the oldtol
and newrtol
kwarg names.Fixes #45.