Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use single quotes for string literals, fixes #2001 #2004

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cldellow
Copy link
Contributor

@cldellow cldellow commented Jan 25, 2023

This modernizes some uses of double quotes for string literals to use only single quotes, fixes #2001

While developing it, I manually enabled the stricter mode by using the code snippet at https://gist.github.com/cldellow/85bba507c314b127f85563869cd94820

I think that code snippet isn't generally safe/portable, so I haven't tried to automate it in the tests.


📚 Documentation preview 📚: https://datasette--2004.org.readthedocs.build/en/2004/

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 92.11% // Head: 92.11% // No change to project coverage 👍

Coverage data is based on head (dca7634) compared to base (e4ebef0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2004   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files          38       38           
  Lines        5555     5555           
=======================================
  Hits         5117     5117           
  Misses        438      438           
Impacted Files Coverage Δ
datasette/utils/__init__.py 94.86% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasette is not compatible with SQLite's strict quoting compilation option
1 participant