Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updateNode being called with undefined rootNode #2

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Fix updateNode being called with undefined rootNode #2

merged 1 commit into from
Sep 29, 2020

Commits on Sep 24, 2020

  1. Fix updateNode being called with undefined rootNode 

    When redux `dispatch()` is called before `getState()` has ever been called, `updateNode()` (in the custom `creatStore()` function) will be called with `rootNode` still undefined.

This wasn't catched in tests as they coincidentally always called `getState()` (for the cache setup) before dispatching. The added test here reproduces the bug that I was seeing when that's not the case.
    @simonihmig
    simonihmig committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    941011f View commit details
    Browse the repository at this point in the history