Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to NX Version 13 #45

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Upgrade to NX Version 13 #45

merged 2 commits into from
Apr 8, 2022

Conversation

BraunreutherA
Copy link
Contributor

As this project doesn't work anymore with NX version 13, this PR changed the V12 createProjectGraph() function to await createProjectGraphAsync('4.0') which is backward compatible through the version number. This only fixes the existing problem with the newer NX version - still the plugin should be refactored to use the new projectGraph Version.

@johngrimsey
Copy link

@simondotm Keen for this one 👍

@ghost
Copy link

ghost commented Dec 30, 2021

Hi @simondotm, is this PR going to be merged any time soon?

@enchorb
Copy link

enchorb commented Jan 15, 2022

@simondotm Would be great to get this merged so we can stop using the patch in prod

@johngrimsey
Copy link

Also, cheers @BraunreutherA 👏

@ziolmar
Copy link

ziolmar commented Jan 18, 2022

+1

1 similar comment
@sk91
Copy link

sk91 commented Jan 24, 2022

+1

@wojtiku
Copy link

wojtiku commented Feb 4, 2022

+1 for this, please :)

@mati0090
Copy link

mati0090 commented Feb 4, 2022

obraz

@victorouse
Copy link

+1

@jiaf-gh
Copy link

jiaf-gh commented Mar 1, 2022

Any news about @simondotm ?

@Hadjimina
Copy link

This would help me out a lot! Thanks for your work @simondotm.

@simondotm
Copy link
Owner

Hi all, apologies for not being on top of this. Please see my post here: #46

Thankyou all for your contributions and suggestions. I had no idea this repo was of such interest and I will do what I can to help it be managed by the community.

To expediate things I will bless this PR without any review since everyone above seems to like it, plus I've also invited BraunreutherA to be a collaborator to start opening this project up to the community.

Cheers
Simon

@simondotm simondotm merged commit 89af0eb into simondotm:main Apr 8, 2022
@romshiri
Copy link

@simondotm Thanks, which version include the fix? When I try to download the latest version (0.3.3) I still get the error this PR suppose to fix.

@simondotm
Copy link
Owner

Hi folks I quickly tried to get a new release out last Friday but the GitHub action failed for some reason.
I'm not at my computer now for a few days so the soonest I can look into it will be this weekend.

@johngrimsey
Copy link

This has been a very helpful lib for me and I'm grateful to @simondotm for his efforts.

At present I'm only running one set of Firebase Functions, and all my individual apps share the same Firebase project.

I've decided to remove this as a dependency from my project and have opted instead for a standard Nx Node app, things are much simpler now for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.