-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to NX Version 13 #45
Conversation
@simondotm Keen for this one 👍 |
Hi @simondotm, is this PR going to be merged any time soon? |
@simondotm Would be great to get this merged so we can stop using the patch in prod |
Also, cheers @BraunreutherA 👏 |
+1 |
1 similar comment
+1 |
+1 for this, please :) |
+1 |
Any news about @simondotm ? |
This would help me out a lot! Thanks for your work @simondotm. |
Hi all, apologies for not being on top of this. Please see my post here: #46 Thankyou all for your contributions and suggestions. I had no idea this repo was of such interest and I will do what I can to help it be managed by the community. To expediate things I will bless this PR without any review since everyone above seems to like it, plus I've also invited BraunreutherA to be a collaborator to start opening this project up to the community. Cheers |
@simondotm Thanks, which version include the fix? When I try to download the latest version (0.3.3) I still get the error this PR suppose to fix. |
Hi folks I quickly tried to get a new release out last Friday but the GitHub action failed for some reason. |
This has been a very helpful lib for me and I'm grateful to @simondotm for his efforts. At present I'm only running one set of Firebase Functions, and all my individual apps share the same Firebase project. I've decided to remove this as a dependency from my project and have opted instead for a standard Nx Node app, things are much simpler now for me. |
As this project doesn't work anymore with NX version 13, this PR changed the V12
createProjectGraph()
function toawait createProjectGraphAsync('4.0')
which is backward compatible through the version number. This only fixes the existing problem with the newer NX version - still the plugin should be refactored to use the new projectGraph Version.