Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rowspan cross multi pages #1031

Open
wants to merge 3 commits into
base: v4
Choose a base branch
from
Open

Conversation

trung37
Copy link

@trung37 trung37 commented Feb 6, 2024

@simonbengtsson
Copy link
Owner

Looks like a great fix! Could you describe your pull request a bit and clean up the title? Also would be great to update the pull request to not include dist files, complexdata.js or font file in addition to run prettier code formatting on the changes.

@trung37 trung37 changed the title rows span acrorss pages https://github.com/simonbengtsson/jsPDF-AutoT… Fix rowspan cross multi pages Feb 15, 2024
@trung37
Copy link
Author

trung37 commented Feb 19, 2024

I added function named "splitRowSpan", consider the row, that had rowspan
I calculated current row height, if it 's height over the avaiable space, I clone the rowspan cell to next rows, and reduce the cell height, ultil number of rows fit to the rowspan cell
keepPage: ensure not break page process by shouldPrintOnCurrentPage function
isBreakPage: ensure break page on the row should be break page

@simonbengtsson
Copy link
Owner

Thougths on merging this @mmghv ?

@mmghv
Copy link
Collaborator

mmghv commented Aug 30, 2024

@simonbengtsson Give me some time I'll have a look at it and see how does it relate to the work I've been doing on v4 regarding spans.

@zhouzhi-zz
Copy link

@simonbengtsson Give me some time I'll have a look at it and see how does it relate to the work I've been doing on v4 regarding spans.给我一些时间,我会看一下它,看看它与我在 v4 上所做的关于 span 的工作有什么关系。

When is the v4 expected to be released, thanks.

@mmghv
Copy link
Collaborator

mmghv commented Sep 4, 2024

When is the v4 expected to be released, thanks.

No dates yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants