-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update package's node + twigjs versions; update travis's node versions; bump #32
Conversation
Sure is! Added 1 to the version specifically so that Note |
We should change travis config (https://github.com/zimmen/gulp-twig/blob/master/.travis.yml) for recent node/npm. |
@ryuran good catch thanks |
package.json
Outdated
@@ -23,7 +23,7 @@ | |||
"test": "mocha -R spec" | |||
}, | |||
"engines": { | |||
"node": ">= 0.9.0" | |||
"node": "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not change this to >=4.0 according Travis & Readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lifted this uncritically from twig.js. >=4.0 makes sense to me.
- "0.10" | ||
- "0.11" | ||
- 4 | ||
- 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also add 8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the dependencies test 8. twig.js
tests 4 and 6. Since Twig is what we care about it makes sense to match its tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point :)
5f5c12a
to
f64df15
Compare
So let's merge this :) |
I think go with 1.0.0 now. For me, dependencies like this should follow semver - so bumping from 0.x to 1.0 is saying "there was a breaking change" not "we've ironed out the bugs." The upgraded node requirement is a breaking change. If we do use a lower version, we'll have to remember to downgrade the version in package.json from the bump in f64df15 |
Updates to the latest twig.js
This PR has gotten bigger. Updated description:
The main purpose of this PR is to use the latest 1.x.y version of
twig.js
gulp-twig
's node requirements have fallen far enough behindtwig.js
's that updating to the latesttwig.js
makesgulp-twig
's tests fail. So this PR also updates node inpackage.json
and.travis.yml
.Upping the node version dependency should be considered a breaking change, so I've bumped to v1. This has the perk of fitting nicely with
twig.js
's versioning. I propose thatgulp-twig
's major version should always be the same as the major version of thetwig.js
dependency.