Skip to content

[Metrics][Prototype] Clean up and refactors#15

Merged
simianhacker merged 2 commits intosimianhacker:metrics/project-bootstrapfrom
crespocarlos:metrics/project-bootstrap-improvements
Aug 12, 2025
Merged

[Metrics][Prototype] Clean up and refactors#15
simianhacker merged 2 commits intosimianhacker:metrics/project-bootstrapfrom
crespocarlos:metrics/project-bootstrap-improvements

Conversation

@crespocarlos
Copy link

Summary

  • Improve type inference
  • Introduces the usage of the ES Traced Client
  • Drops the usage of React.FC
  • Reorg server folders (I'm still on the fence about the libs folder)
  • Implements a typed server client for API calls

@crespocarlos crespocarlos changed the title refactor: improve types; reorg folders; drop React.FC usage [Metrics][Prototype] Clean up and refactors Aug 12, 2025
preset: '@kbn/test',
rootDir: path.resolve(__dirname, '../../../../..'),
roots: ['<rootDir>/x-pack/platform/plugins/shared/apm_sources_access'],
roots: ['<rootDir>/x-pack/platform/plugins/shared/metrics_experience'],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... my secret is out... I copied that file from apm_sources_access 🤪

Copy link
Owner

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... GOOD CLEAN UP!

@simianhacker simianhacker merged commit 93b217b into simianhacker:metrics/project-bootstrap Aug 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants