Skip to content

Commit

Permalink
Hide CoreLogging.catch_exceptions behind runtime dispatch
Browse files Browse the repository at this point in the history
  • Loading branch information
timholy authored and simeonschaub committed Aug 11, 2020
1 parent c4b5f76 commit 022c28d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion base/logging.jl
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ end

_invoked_min_enabled_level(@nospecialize(logger)) = invoke(min_enabled_level, Tuple{typeof(logger)}, logger)

_invoked_catch_exceptions(@nospecialize(logger)) = invoke(catch_exceptions, Tuple{typeof(logger)}, logger)

"""
NullLogger()
Expand Down Expand Up @@ -349,7 +350,7 @@ end
# Report an error in log message creation (or in the logger itself).
@noinline function logging_error(logger, level, _module, group, id,
filepath, line, @nospecialize(err))
if !catch_exceptions(logger)
if !_invoked_catch_exceptions(logger)
rethrow(err)
end
try
Expand Down

0 comments on commit 022c28d

Please sign in to comment.