Add class to trait visitor. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us replace classes that extend certain other classes with a provided list of traits.
maxime-rainville
previously requested changes
Feb 18, 2019
There was a problem hiding this comment.
It looks like it's working well. I tested with an abstract class and a class that implements some interfaces and it all worked.
My main beef is that the use Trait statement gets added at the end of the class just before the closing bracket. Any chance we could move those statement to the top of the class just after the opening backet?
|
Travis build failure is just some linting issue. |
- Add better test case
…stripe-upgrader into pulls/class-to-trait
maxime-rainville
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us replace classes that extend certain other classes with a provided list of traits.