Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR Don't add PHP constructs (e.g. integer) to the use statement #151

Conversation

maxime-rainville
Copy link
Contributor

Fixing #150

This is not valid php.

<?php
use integer;
use string;

function intToString(integer $val): string
{
    return (string)$val;
}

This PR simply adds PHP types to the list of words that should be ignored when adding use statements.

*/
public function testNamespaceUseStatement()
{
list($parameters, $input1, $output1) =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these variables do not need to be numbered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@bergice bergice merged commit fe01c23 into silverstripe:master Jan 23, 2019
@maxime-rainville maxime-rainville deleted the pulls/1/dont-add-use-statement-for-scalars branch January 23, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants