FIX: NestedInputBuilder doesn't work with nested '*' #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Jun 12, 2023
There was a problem hiding this comment.
Thank you for this PR, this is an excellent contribution!
This bug fix should be applied to the CMS 4 compatible version of the module as well. Please retarget this PR to the 4.3 branch. You'll need to reset your PR branch so that it doesn't carry over commits from 5.
| if (isset($fields[Schema::ALL]) && $fields[Schema::ALL]) { | ||
| unset($fields[Schema::ALL]); | ||
| $fields = array_merge($fields, $this->buildAllFieldsConfig($type)); | ||
| } | ||
| foreach ($fields as $fieldName => $data) { | ||
| if ($fieldName === Schema::ALL) { |
There was a problem hiding this comment.
This if statement (if ($fieldName === Schema::ALL) { inside the foreach loop) is dead code since you've added unset($fields[Schema::ALL]); above. Please remove it.
|
I don't have permissions to directly modify this PR so it has now been superceded by #538 which includes the requested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #535