API Replace FormActions with anchors to enable panel-based loading in GridField navigation buttons #8953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ScopeyNZ
suggested changes
May 1, 2019
ScopeyNZ
approved these changes
May 1, 2019
robbieaverill
force-pushed
the
pulls/4.4/better-button-fixes
branch
from
90f2029
to
aa649dc
Compare
robbieaverill
commented
May 1, 2019
| $previousAndNextGroup->addExtraClass('circular-group mr-2'); | ||
| $previousAndNextGroup->setFieldHolderTemplate(get_class($previousAndNextGroup) . '_holder_buttongroup'); | ||
| $previousAndNextGroup->addExtraClass('btn-group--circular mr-2'); | ||
| $previousAndNextGroup->setFieldHolderTemplate(CompositeField::class . '_holder_buttongroup'); |
There was a problem hiding this comment.
This would've resulted in a fatal error (template not found) if CompositeField was rerouted with Injector to MyCompositeField
robbieaverill
commented
May 1, 2019
…w buttons in GridFields
… GridField navigation buttons
unclecheese
force-pushed
the
pulls/4.4/better-button-fixes
branch
from
d138d9f
to
a71d363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the Prev, Next, and New buttons in GridField "better buttons" from FormActions to simple anchors. Doing this means that (a) they don't have their own loading indicators, and (b) the CMS panel automatically obtains a loading indicator while processing.
None of these actions are POST actions, so don't need to be FormActions (technically speaking).
This also adds tooltips and ARIA labels for accessibility to these buttons, and changed the new class names for circular buttons to be more BEM compliant.
Issue: silverstripe/silverstripe-admin#815
Note: this is removing public API, but those were added in #8569 and haven't been tagged in a stable release yet. They aren't needed for anchor based buttons, so I've deleted them.