BUGFIX: Fix error notification on files (fixes: 7295) #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add title text to all status messages Make room for the error message details by expanding the name area in the file details Fix up changes status to work with selects
| }); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
UploadField shouldn't make any assumptions about the UI controls used in the edit form (like chosen.js) - I've refactored this to a more generic onchange listener
There was a problem hiding this comment.
Ahh, was wondering how to do that. :)
chillu
added a commit
that referenced
this pull request
May 11, 2012
--- Add title text to all status messages Make room for the error message details by expanding the name area in the file details Fix up changes status to work with selects http://open.silverstripe.org/ticket/7295
sabina-talipova
pushed a commit
to creative-commoners/silverstripe-framework
that referenced
this pull request
Oct 18, 2022
…en dimensions are not numeric (silverstripe#436) * Cast image dimensions from shortcode as int This prevents sizes like '50%' from triggering exceptions. Fixes silverstripe#434 (or at least prevents an exception) * Add a test for non-integer imagesize handling in shortcodes Quick/first attempt... * Escape legit percent sign in sprintf string Co-authored-by: Maxime Rainville <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add title text to all status messages
Make room for the error message details by expanding the name area in
the file details
Fix up changes status to work with selects
http://open.silverstripe.org/ticket/7295