API Remove CMSPreviewable interface from BaseElement #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests are fixed in #215. I'd like to merge up this change to the master branch before merging this though, so we can add some variety to the matrix |
This was referenced Apr 11, 2018
robbieaverill
force-pushed
the
pulls/3.0/remove-previewable
branch
from
82390c9 to
16d7e4b
Compare
Previews are managed by silverstripe/versioned-admin in SS 4.2 and newer, so this interface is not necessary.
…date CMS version Minimum CMS version bumped to 4.2 to include silverstripe/versioned-admin with the history viewer. Previos history components for elemental are removed in favour of this new React implementation.
robbieaverill
force-pushed
the
pulls/3.0/remove-previewable
branch
from
16d7e4b to
53499a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previews are managed by silverstripe/versioned-admin in SS 4.2 and newer, so this interface is not necessary.
This PR also removes the old history implementation in favour of using silverstripe/versioned-admin, and increases the core requirement to 4.2