FIX Allow publishing non-inline-editable blocks #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5.3/publish-noninline-block
branch
from
f3659fe to
d931f0a
Compare
This was referenced Jan 30, 2025
emteknetnz
requested changes
Feb 2, 2025
GuySartorelli
force-pushed
the
pulls/5.3/publish-noninline-block
branch
from
d931f0a to
28461ef
Compare
emteknetnz
requested changes
Feb 5, 2025
There was a problem hiding this comment.
I performed and updated kitchen sink CI run where there was a failing behat test with the latest PRs - https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/13148450879
That is not an existing failure - https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/13148969515
|
I would be shocked if this small change to elemental's react components broke the CMS behat for real. Alerts are usually intermittent failures in behat - I've rerun the failure and will take a look when it's done. Edit: Went green after rerunning it. |
emteknetnz
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs silverstripe/silverstripe-frameworktest#225 for CI to go green, so merge that first
Issue