FIX Forwarding action state in another situation where it was not being forwarded #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #757 . There's a relatively uncommon way that the new
AttributeStoremethod of passing around GridField action state could fail if you used the React GridFieldActions component but you had one action that was not edit. In this case the dropdown was not rendered, instead there is a single button. When that button was edit it uses a different part of entwine and works correctly but if it's any other action (eg. delete) then the action state is not present and the action fails.Fixes silverstripe/silverstripe-framework#8675