Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Dec 8, 2025

This PR fixes a bug where Scripture Forge should send an empty string to Serval to not train on any books, when no books were selected by the user.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.76%. Comparing base (c4a8e75) to head (67024cf).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...XForge.Scripture/Services/MachineProjectService.cs 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3606      +/-   ##
==========================================
- Coverage   82.77%   82.76%   -0.01%     
==========================================
  Files         610      610              
  Lines       37235    37236       +1     
  Branches     6080     6105      +25     
==========================================
  Hits        30820    30820              
+ Misses       5498     5485      -13     
- Partials      917      931      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 self-assigned this Dec 9, 2025
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@RaymondLuong3 reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Dec 9, 2025
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Dec 10, 2025
@Nateowami Nateowami enabled auto-merge (squash) December 10, 2025 15:27
@Nateowami Nateowami merged commit c1d2325 into master Dec 10, 2025
26 checks passed
@Nateowami Nateowami deleted the fix/SF-3662 branch December 10, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants